Raise error from waitress if not shutdown #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mig5
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1787
This seems to be a non-linux issue. I was unable to reproduce the error in linux, but got the error when testing in mac. In mac, when the server is stopped, for some reason (probably a thread waiting) waitress tries the creation function and raises error, which causes the modal to show. When reviewing the waitress PR, I and @mig5 had a similar discussion. I think we might have misunderstood why the code example we followed was using the
was_shutdownattribute. I think this might be exactly why, since in some cases the create server is called while it's getting shutdown, and in that time the error doesn't need to be raised/shown.