Make it possible to supply a custom json settings file from somewhere else #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for thoughts on this (seems to work) - as mentioned in #436
By making it possible to pass a custom json settings file either in CLI or GUI mode, the following becomes possible in future:
Check for presence of this --config arg, and if present, skip the 'first time' tour planned in OnionShare onboarding process #436
Means we can store a custom json in the tests/ dir (or write one as part of each on-demand test) that has settings for system Tor, thus speeding up/preventing from blocking Travis tests by not having to try and bootstrap bundled mode
Means config isn't kept on main OS disk which might help conceal previous use of Onionshare on a computer / make it more portable (see [Feature request] "Portable" settings #366)