[WIP] Bugfix: 'inoremap jk <esc>' doesn't work as expected

[bryphe]

No description provided.

[CrossR]

I've fixed this building (wasn't happy on mac) and tried to get to the bottom of it, but I'm still not so sure what is causing the issue.

The only insight I have is that after doing :inoremap jk <esc> in Oni2 has a weird timeout setting of some form, in that after entering insert mode and typing j, there is nothing shown for any length of time, until the second key is pressed. Pressing j after that point works as normal. Dropping back to normal mode and entering insert mode does the same again for the first press and so on.

The timeout seems to be set correctly, and I can see the map is actually set, but not why it isn't working. I think this is blocking all other maps that are chord like (I've got commentary loading locally and :Commentary works, but the built in bind does not, so its not an insert map issue but maps as a whole).

[bryphe]

I've fixed this building (wasn't happy on mac) and tried to get to the bottom of it, but I'm still not so sure what is causing the issue.

Cool, thanks for the help here @CrossR !

One suspicion I have is that there are a few counters that are used to 'block' mappings - things like this:

libvim/src/normal.c

Line 1038 in 282ef59

++no_mapping;

There's a few of these counters:

• no_mapping
• allow_keys

And then this is used in getchar when deciding if a key is mappable:

libvim/src/getchar.c

Line 1972 in 282ef59

* - no_mapping set: mapping disabled (e.g. for CTRL-V)

I'm curious if maybe our 'state machine' isn't handling this correctly - there might be cases where we aren't properly incrementing / decrementing those values after refactoring to the state machine.

One other thing - there isn't a mechanism for handling the timeout, I believe - I think the way it works is that Vim expects a K_CURSORHOLD character:

libvim/src/normal.c

Line 345 in 93ebc62

{K_CURSORHOLD, nv_cursorhold, NV_KEEPREG, 0},

And I think we'd need to send that occasionally to time out Vim.

I've got commentary loading locally and :Commentary works, but the built in bind does not, so its not an insert map issue but maps as a whole).

Nice! That's promising. If we can get these binds working, that's a great step towards more Vim plugin support.

[bryphe]

This is now handled in the Onivim layer - no longer needed here.