Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Oni frequent crash on Windows 7 #490

Closed
saibing opened this issue Jun 19, 2017 · 5 comments
Closed

Oni frequent crash on Windows 7 #490

saibing opened this issue Jun 19, 2017 · 5 comments

Comments

@saibing
Copy link

saibing commented Jun 19, 2017

Oni frequent crash on Windows 7, such as the following scenario will crash:

  • enter dd consecutively to delete text line.

  • quick open file.

Oni version:

* fa8a529 (HEAD -> master, origin/master, origin/HEAD) Fix #407, use editor.quickOpen.execCommand to filter files in qui
ckOpen (#489)
@bryphe
Copy link
Member

bryphe commented Jun 20, 2017

Thanks for reporting this, @saibing !

I've seen random crashes on Windows 10 as well. It looks like that the Neovim process is actually closing, and then Oni quits in response to that.

It might be related to a couple of crashes reported in Neovim:

There's also the possibility that some of the work Oni is doing (like incremental buffer updates) is exacerbating an existing crash in Neovim. I need to see if there is more info I can get from the actual crash in Neovim.

A couple questions though that might help narrow this down:

  • What does your config.js look like? Have you modified it at all?
  • Are you using any vim plugins?

@saibing
Copy link
Author

saibing commented Jun 21, 2017

@extr0py

my oni config's content as follow:

module.exports = {
  //add custom config here, such as
  //"oni.useDefaultConfig": true,
  "oni.loadInitVim": false,
  "editor.fontSize": "15px",
  "editor.fontFamily": "Source Code Pro",
  "editor.quickOpen.execCommand": "fzf -f ${search}"
}

@badosu
Copy link
Collaborator

badosu commented Oct 3, 2017

I think this must be windows related as I have used Oni for a month now and did not have a single crash.

bryphe added a commit that referenced this issue Oct 6, 2017
#490 - Part 2 - Automated stability test
bryphe added a commit that referenced this issue Oct 13, 2017
* Add some debugging settings to narrow down the crash

* Add logging for command

* Switch default for persistOnNeovimExit

* Fix lint issues
@bryphe
Copy link
Member

bryphe commented Oct 26, 2017

The good news here is I've been testing out a new nightly build and it seems much more stable on Windows (no crashes). I'll plan on upgrading Oni to use 0.2.1 as soon as it is out.

@bryphe
Copy link
Member

bryphe commented Nov 8, 2017

Upgraded to neovim 0.2.1 addresses this - #875 (at least, haven't seen any crashes!).

Feel free to open a new issue if you are still seeing this, though. I'm going to cut a new release shortly with neovim 0.2.1 binaries.

@bryphe bryphe closed this as completed Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants