This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix regression in opening files from command line #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Passing a file as an argument to Oni isn't working. This also breaks Windows shell extensions, since they rely on passing the file as an argument.
Defect: This is a regression from one of the automation stability fixes. The automation passes a bunch of arguments to Oni, and this can cause some timing issues (it will attempt to load additional files, whereas the test case may not expect it). We added a filter so that, if the arguments are from automation, we ignore it - but the filter's logic wasn't correct.
Fix: Correct the logic for filtering automation arguments.