This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 301
Bugfix/open new file after close #1246
Merged
bryphe
merged 22 commits into
onivim:master
from
akinsho:bugfix/open-new-file-after-close
Jan 16, 2018
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bfe8b49
return main window and create one if unavailable
akinsho 6931f09
hide window on "close" so object not destroyed
akinsho 9a8cefd
add accelarator options
akinsho db94d3b
explicitly pass in focused window to menu clicks
akinsho d55e250
create fn ensure window always exists
akinsho 57801c3
use browser window for oni command
akinsho 51ea581
create ref to main window to use on activate
akinsho 79cb04f
Fix incorrect conditional for windows.length
akinsho 1fb7435
fix unintentional command rename
akinsho ad1d62e
re-add old conditional with better ordering
akinsho 277e7b4
remove hiding functionality
akinsho da45517
Fix rename bugs remove traces of quitting state
akinsho ca34523
add delayed event sending
akinsho 744587f
merge upstream and fix main.ts conflicts
akinsho c5a3d40
merge upstream and fix conflicts
akinsho b0f534a
add event on oni.started listened for in main
akinsho ce01b4c
Merge branch 'feature/delayed-start-events' into bugfix/open-new-file…
akinsho dd544da
send delayed event to main process
akinsho 26bd23d
create dryer wrapper fn
akinsho 9d08ed2
switch to using once method for ipcMain
akinsho b929b75
revert changes to oni.sh
akinsho a3f4499
finish reverting oni.sh changes
akinsho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks great to me - thanks @Akin909 !