Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

#55 - Part 1 - Initial snippet service #1284

Merged
merged 9 commits into from Jan 19, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jan 12, 2018

  • Integrates vscode-snippet-parser for snippet parsing logic
  • Adds unit tests + scaffolds service via Oni.snippets.insertSnippet, ie: Oni.snippets.insertSnippet("foo${1:test}")

Remaining work:

  • Properly handle placeholders
  • Hook up selection / placeholder tab stops
  • Synchronize updates from buffer
  • Integration as a completion provider
  • Add ability for plugins to contribute snippets, and bring default set in

@Contextualist
Copy link

Any plan on intergrating the snippet kind of language server's completion (i.e. TextDocumentClientCapabilities.completion.completionItem.snippetSupport. See also CompletionItem.insertTextFormat) ?

@bryphe
Copy link
Member Author

bryphe commented Jan 13, 2018

@Contextualist - yes, definitely! Logged an issue to track that integration specifically (#1291)

@Miszo97
Copy link

Miszo97 commented Jan 17, 2018

@bryphe Great job! How long does it take to release binaries? :)

@bryphe
Copy link
Member Author

bryphe commented Jan 17, 2018

@bryphe Great job! How long does it take to release binaries? :)

Not hard to release binaries - but this is only the very first change for snippets (just "part 1") - still a lot more work to be done to have it be usable.

@bryphe bryphe changed the title [WIP] #55 - Part 1 - Initial snippet service #55 - Part 1 - Initial snippet service Jan 17, 2018
@bryphe
Copy link
Member Author

bryphe commented Jan 19, 2018

Ran the OSX tests locally on 0c1ab12, they were green

@bryphe bryphe merged commit fef2e10 into master Jan 19, 2018
@bryphe bryphe deleted the bryphe/55.1/initial-snippet-service branch January 19, 2018 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants