Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

remove icon for default command line #1293

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Jan 14, 2018

@bryphe apologies re the bugs with #1249 🙇 , this PR just removes the case for the icon for : so there is no default icon as discussed in #1249 without any octicon baggage. Should be bug free just a small deletion.

@bryphe
Copy link
Member

bryphe commented Jan 15, 2018

@bryphe apologies re the bugs with #1249 🙇

Haha, no worries! It's unfortunately easy to break, especially since there isn't a test covering this developer case. I've broken this too before.

Appreciate your understanding - thanks for bringing back the icon fix!

@bryphe
Copy link
Member

bryphe commented Jan 15, 2018

Looks good to me! Bringing this in now 👍

@bryphe bryphe merged commit 056ec8b into onivim:master Jan 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants