This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix #1296: Colors not showing correctly for some themes #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: For some vim themes, the colors aren't calculated / respected properly.
Defect: For themes that don't have json colors specified, we derive the colors, and let the
Colorsclass handle them. We were only listening toThemechange events, but actually we want to listen to theColorschanged events, because themes aren't the only way the colors can change - we also support changing colors from configuration.Fix: Listen to
Colorsobject directly