This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tslint
andprettier
were in conflict for some settings (we already have thesemicolon
rule disabled, so wasn't clear why there were still flags on the js files).I did some research and it looks like we can have
tslint
ignore files, but need to upgrade. The new version oftslint
picked up a few extra errors, like unnecessaryawaits
, so I ranfix-lint
over the codebase too.