This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix error when using Open With option in OSX finder #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2366 +/- ##
==========================================
+ Coverage 38.07% 38.11% +0.03%
==========================================
Files 300 300
Lines 12508 12519 +11
Branches 1645 1645
==========================================
+ Hits 4763 4771 +8
- Misses 7491 7494 +3
Partials 254 254
Continue to review full report at Codecov.
|
akinsho
reviewed
Jun 29, 2018
main/src/main.ts
Outdated
| if (app.isReady()) { | ||
| createWindow(argsToUse, process.cwd()) | ||
| } else { | ||
| app.on("ready", async () => { |
There was a problem hiding this comment.
@psxpaul thanks so much for the fix 馃憤 , One quick note is that the app.on("ready") callback is an async function in your change but we dont await createWindow which I believe is sync, its I think, a minor point but is it intentional?
There was a problem hiding this comment.
Thanks for the feedback! I removed the async keyword and re-tested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041. I've never done anything with Electron or Typescript, so let me know if I'm doing anything crazy here 馃槂.