Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Jump to files/directories created in the Explorer #2468

Merged

Conversation

feltech
Copy link
Contributor

@feltech feltech commented Jul 26, 2018

  • Add a SELECT_FILE action as the last step in CREATE_NODE_COMMIT so
    that files created in the explorer are scrolled and highlighted.
  • SELECT_FILE has the same effect as EXPAND_DIRECTORY + REFRESH,
    so no need to include those as well.
  • Updated unit tests.

* Add a `SELECT_FILE` action as the last step in `CREATE_NODE_COMMIT` so
that files created in the explorer are scrolled and highlighted.
* `SELECT_FILE` has the same effect as `EXPAND_DIRECTORY` + `REFRESH`,
so no need to include those as well.
* Updated unit tests.
@feltech
Copy link
Contributor Author

feltech commented Jul 26, 2018

I found it a bit annoying when I created files via the Explorer in a large directory, and the file I created disappeared from view, because it was alphabetically sorted away. So this PR uses the recently added SELECT_FILE action to jump to the newly created file.

@codecov
Copy link

codecov bot commented Jul 27, 2018

Codecov Report

Merging #2468 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2468   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files         343      343           
  Lines       13694    13694           
  Branches     1800     1800           
=======================================
  Hits         6010     6010           
  Misses       7445     7445           
  Partials      239      239
Impacted Files Coverage Δ
browser/src/Services/Explorer/ExplorerStore.ts 80.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bdb4b...82c6013. Read the comment docs.

Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for adding this @feltech 👍

@akinsho akinsho merged commit b2ef17f into onivim:master Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants