Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Fix for 2272 - <f12> opens in current tab #2504

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Conversation

psxpaul
Copy link
Contributor

@psxpaul psxpaul commented Aug 14, 2018

This is a fix for #2272 to make language.gotoDefinition use the Oni.DefaultFileOpenOptions.openMode setting by default. It also adds:

  • language.gotoDefinition.openNewTab
  • language.gotoDefinition.openEdit
  • language.gotoDefinition.openExistingTab

so that users can create bindings for the specific behavior they want.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #2504 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2504      +/-   ##
==========================================
+ Coverage    44.2%   44.22%   +0.01%     
==========================================
  Files         344      344              
  Lines       13886    13882       -4     
  Branches     1829     1828       -1     
==========================================
+ Hits         6138     6139       +1     
+ Misses       7508     7503       -5     
  Partials      240      240
Impacted Files Coverage Δ
...er/src/Editor/NeovimEditor/NeovimEditorCommands.ts 12.28% <0%> (+0.95%) ⬆️
browser/src/Editor/NeovimEditor/Definition.ts 31.57% <0%> (+9.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a54bb2c...ad97734. Read the comment docs.

Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psxpaul sorry for the delay reviewing this, looks good to me 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants