Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Feature/Add vue textmate grammar #2582

Merged
merged 2 commits into from Oct 3, 2018

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Sep 25, 2018

This PR adds a language grammar for vue js, relates to #1927, where the absence of a textmate grammar was discussed.
The grammar was sourced from here

@akinsho akinsho changed the title This PR adds a language grammar for vue js Feature/Add Vue Textmate grammar Sep 25, 2018
@CrossR
Copy link
Member

CrossR commented Sep 27, 2018

Does this need adding to/linking in the default config as well?

@akinsho
Copy link
Member Author

akinsho commented Oct 1, 2018

@CrossR 👍 it does indeed completely forgot will fix

@akinsho akinsho changed the title Feature/Add Vue Textmate grammar Feature/Add vue textmate grammar Oct 3, 2018
@akinsho akinsho force-pushed the feature/add-language-grammar-for-vue branch from 144148c to 429e62a Compare October 3, 2018 15:40
@akinsho
Copy link
Member Author

akinsho commented Oct 3, 2018

@CrossR I've tweaked this to add in the path to the default config if you get a chance to have a look again

@akinsho akinsho requested a review from CrossR October 3, 2018 15:41
Copy link
Member

@CrossR CrossR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now its linked!

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #2582 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2582   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files         361      361           
  Lines       14575    14575           
  Branches     1912     1912           
=======================================
  Hits         6601     6601           
  Misses       7750     7750           
  Partials      224      224
Impacted Files Coverage Δ
...src/Services/Configuration/DefaultConfiguration.ts 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af72e43...429e62a. Read the comment docs.

@akinsho akinsho merged commit ff1a064 into onivim:master Oct 3, 2018
@akinsho akinsho deleted the feature/add-language-grammar-for-vue branch October 3, 2018 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants