This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When using
:q
to close the app, all open Oni windows also close. This is very frustrating and annoying.Defect: The app uses electron's
makeSingleInstance
functionality, which means there is only one 'main' process and multiple 'browser' processes. When usingremote.app.quit()
this would close all instances.Fix: When an individual instance quits, just close the browser window instead of killing the whole app and all browser windows.