This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix #553: Add additional, optional paths to spawned processes #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: There are some differences in the
PATHsettings sent to Oni, depending on how it was launched (terminal, dock, etc), and depending on the platform. Some of the language server processes (and other extensibility points) depend on having some common binaries, like node or python accessible.Defect: There isn't a guarantee that we will get all the necessary paths from the environment Oni is opened from.
Fix: Add a setting that allows additional
PATHs to be added to Oni - regardless of where it is executed.