This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fixes #579 - Backwards Compatibility for Neovim Versions #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The tabline feature, to integrate with vim tabs, uses the
external_tablineparameter for attaching to UI. If we try and pass that to an earlier version of Neovim, the attach will fail.Defect: We weren't caring about the version or level of API support for the API instance.
Fix: Query Neovim for the version, and decide what startup options to send it based on the version.
Longer-term, it would be nice to refactor this in a cleaner way, so that there isn't a giant mess of if / switch statements. In addition, there might be other cases we need to handle backwards compatibility, aside from the
startupOptionsparameter.Fixes #579 (at least on my Linux machine, running 0.2.0-dev neovim).