Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

[WIP] Fix #484 - Update to use asynchronous strategy for menu window #769

Closed
wants to merge 1 commit into from

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Oct 7, 2017

Issue: Many of the menu options rely on there being an Oni window active - which isn't always the case in OS X.

Fix: Extract out an asynchronous strategy for fetching the current window. This is basically a getOrCreate - if there is an existing window, we use that, otherwise we create a new one.

There is an open issue though - there are some menu options that make sense to have when there is no window open (like new file, or open file), but there are also some that only make sense in the context of a window or active editor context - like saving a file. As part of this, I'm investigating having aspects of the menu be controlled by the active editor - so in the case where a window is not active, we'd show a limited set of hardcoded options. However, I'd like to integrate this with the set of commands, and have the active editor "push up" available commands (so that even plugins could register their own commands). I think it makes sense to have the browser window be able to augment this set of commands, by exposing an ApplicationMenu concept on the renderer side, and hooking in the command manager to it (so as part of the metadata of a command, the menu path could also be specified..)

@bryphe
Copy link
Member Author

bryphe commented Jan 11, 2018

This is addressed by #1246 now - closing it out!

@bryphe bryphe closed this Jan 11, 2018
@bryphe bryphe deleted the bryphe/484/new-window-after-quit branch July 4, 2018 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant