This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Make notification handler be more immutable #794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates a new array array instead of mutating the existing array
a
.While playing and debugging the neovim Session code, I noticed that a lot of the data I was consoling out from the notification event handler was missing the command name. It is because the arguments array returned from the notification event was being mutated in place by this code. Objects in the console are late bound, so they don't know their values at the time of logging.