This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Re-architecture of language clients to support configuration #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ILanguageProcess level
bryphe
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty massive PR, and does the following:
language.<filetype>.languageServer.command. The existing plugins (clangd,golang,python, andreason, have been refactored to use these new providers).PluginManager- there was some unnecessary complexity in the interop between how we communicate with the plugins and language servers. The responsibility is now managed by the code in theServices/Languagefolder, withLanguageManagerbeing the main interaction point.Oni.languagesAPI. This allows plugins to programmatically make language server requests (and makes it easy to test!),Symbol Searchis accessible byMeta+Ton OSX andCtrl+Ton Windows, if the language server supports it.Renameis supported (F2in normal mode) ,and refactoring / code actions are actually supported too, but the UX needs to be improved here.This also adds a couple more APIs:
Oni.contextMenuAPI to be able to create a completion-like menu programmatically (this is leveraged by the refactoring code).In addition, our existing TypeScript / JS language providers go through the same end code path, so things like the language status bar work the same in that language (it's been moved to a pseudo-language server).
There is still work to be done, especially around smoothing out the UX for some of the new functionality.