Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Komi value of 5.5 displayed in preferred settings (and perhaps elsewhere) when komi is automatic #2527

Closed
dexonsmith opened this issue Jan 28, 2024 · 0 comments · Fixed by #2528
Closed

Komi value of 5.5 displayed in preferred settings (and perhaps elsewhere) when komi is automatic #2527

dexonsmith opened this issue Jan 28, 2024 · 0 comments · Fixed by #2528
Assignees
@dexonsmith

Comments

@dexonsmith
Copy link
Contributor

E.g.:

eaf8ccf3ace7fa6f1c594c215edbeb630fb0ede8

The komi should probably be skipped from the description. Or it could be "automatic". But it says "5.5".

This is just a display bug; when the game is created, it has the correct komi.
@dexonsmith dexonsmith self-assigned this Jan 28, 2024
dexonsmith added a commit to dexonsmith/online-go.com that referenced this issue Jan 28, 2024
@dexonsmith
Only show custom komi in challenge descriptions
afff2d4 
The `komi` field is inaccurate (and ignored) when `komi_auto !== "custom"`.  It
might be nice to show the automatic komi, but right now that would be hard to
do so consistently, since for small boards it depends on handicap tables that
are server side.

For now, just stop showing komi at all unless `komi_auto === "custom"`.

Fixes online-go#2527.
@dexonsmith dexonsmith mentioned this issue Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dexonsmith dexonsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show custom komi in challenge descriptions dexonsmith/online-go.com
1 participant
@dexonsmith