Mark annulled games more clearly. #1245
Conversation
| @@ -29,13 +29,11 @@ import {PlayerIcon} from 'PlayerIcon'; | |||
| import {GameList} from "GameList"; | |||
| import {Player} from "Player"; | |||
| import * as preferences from "preferences"; | |||
| import {updateDup, alertModerator, getGameResultText, ignore} from "misc"; | |||
There was a problem hiding this comment.
don't think you meant to remove the alertModerator import here? it wasn't related to displaying the endstate of the game
There was a problem hiding this comment.
You are correct that it is unrelated, but alertModerator is an unused import (courtesy of my linter). I'm guessing it fell off whenever that functionality was moved into PlayerDetails.
If you think I should remove that kind of stuff for better chance at being approved, I will, but I thought it was a good idea to tidy up while I was looking at that file.
There was a problem hiding this comment.
just caught my eye, I can't recommend one way or another... anoek may advise whether cleanup should have its own PR or not, frankly it's not my call I just wanted to see why it was included
There was a problem hiding this comment.
If you're curious, commit b88bc3369f17e5036d309ff96cf1e559b83bc2e1 is when alertModerator was removed from the profile page :)
|
I think I fixed it, however I am not sure how to test translations:
I assume 'annulled' is already in the dictionary... does the context parameter for |
|
Yep "annulled" is already in there, as is "Game has been annulled", "Annulled", and "game annulled". So "Game Annulled" isn't in there yet, but close variations are. I would say if "Game has been annulled" looks good there (like it's not too big or doesn't look funny) lets go with that, otherwise we'll just add "Game Annulled" to the list and give the translators some more work to do :) |
|
I guess for "annulled" just make that |
|
Okay, I went ahead and submitted the change to 'annulled': I did not submit the change to "Game Annulled" because changing it to "Game has been annulled" did not translate when I tested in Spanish, and therefore (hopefully) not too much work to translate both in one go. |
|
Awesome thanks! |
|
Nice one! |
Fixes #1244
Proposed Changes