Fixed Puzzle goban container overlay blocking buttons in wide view #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of PR #1298
overflow: hiddenwas removed from.center-colinPuzzle.styl. This caused the goban container to extend over the buttons making it so you can no longer press them. This fixeswideview mode (the most commonly used mode). Sometimes the goban container can still extend down over the buttons on mobile, but that doesn't always happen and it's a harder fix, so I just wanted to get this one pushed out since it affects more people.I'll fix all of these mobile issues (including #1300) in a future PR.
@anoek Puzzles are currently pretty broken without this fix, so probably worth getting this one deployed when you've got a minute.