Various fixes for game popup in rating chart #1514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Proposed Changes
Got rid of renderWinLostResultsAsText in the by-game component, for now. This is actually buggy in the original chart component: the render of this extends below the extent of the element (it looks like vertical clip was turned off to allow this). but due to fortunate spacing in the rating-by-time case, it looks almost OK.
I couldn't quickly work out how to solve this properly - the whole "calculation of the height of various elements" needs a big tidyup to be comprehendable, then this fix would probably be easy. In the mean time, simply not showing it works.
The turning off and on of pie chart had some buggy cases during resize even in the original - that should be fixed now (I had thought that pushing it off to the right offscreen was enough, but it turns out sometimes it can sneak onscreen in thin form factors, so now it is completely un-rendered)