Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for game popup in rating chart #1514

Merged
merged 1 commit into from Aug 15, 2021

Conversation

GreenAsJade
Copy link
Contributor

Fixes:

  • Lingering PieChart artifacts on resize (corner cases)
  • Display of game hover popup when pie chart won't fit (don't do that)
  • Overlapping textual win-loss information in by-game chart in phone form factor (don't display this info, for now)
  • Display of meaningless points when game is finished (don't do that)
  • Display result of game that is finished in the title (do do that)

Proposed Changes

Got rid of renderWinLostResultsAsText in the by-game component, for now. This is actually buggy in the original chart component: the render of this extends below the extent of the element (it looks like vertical clip was turned off to allow this). but due to fortunate spacing in the rating-by-time case, it looks almost OK.

I couldn't quickly work out how to solve this properly - the whole "calculation of the height of various elements" needs a big tidyup to be comprehendable, then this fix would probably be easy. In the mean time, simply not showing it works.

The turning off and on of pie chart had some buggy cases during resize even in the original - that should be fixed now (I had thought that pushing it off to the right offscreen was enough, but it turns out sometimes it can sneak onscreen in thin form factors, so now it is completely un-rendered)

@anoek anoek merged commit e8d55f7 into online-go:devel Aug 15, 2021
@anoek
Copy link
Member

anoek commented Aug 15, 2021

Thanks for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants