Game history rengo merge

[benjaminpjones]

Implements https://forums.online-go.com/t/rengo-status/40415/483

Proposed Changes

• Refactor game_history_groomer: this function was really long (120 lines!), so I broke out some logical functions. It's still pretty long but now it's half the length and fits on one "page".
• Make the normal columns handle rengo games (sort of)
• Remove the rengo-specific table
• Add some types to the Game History table

Notes

I could use some API support:

• player lists or at least number of players for rengo matches
• Fix the game result fields (black_lost, white_lost) i hear a fix is in flight :)
• include the player whose page we are on in the game.players and game.historical_ratings (currently it just picks a player at random from each team?)

(screenshot from Sophiam's page)

[GreenAsJade]

I could use some API support:

• player lists or at least number of players for rengo matches

I submitted a fix for this.

include the player whose page we are on in the game.players and game.historical_ratings (currently it just picks a player at random from each team?)

Pseudo random of course. I think it is the first players on each team :)

This looks to need some thought from anoek, due to gotchas (we only have those two player's full details at the time this is being serialised)

We could easily make it send nothing instead?

[benjaminpjones]

• player lists or at least number of players for rengo matches
  I submitted a fix for this.

Awesome, thanks!

We could easily make it send nothing instead?

If there are significant technical barriers, I suppose nothing is fine, but if we want to populate the rank column consistently, I think the player-of-interest needs to show up in the historical_rankings somehow.

[GreenAsJade]

I have a path forward to deliver the historical rating for the person who's page we are on.

The weird thing is that this api also returns the ratings for the player of the "other" colour. In that case, I think I continue to return the "random" player in the "opposite" field - what else could it be?

Edit: there's a backend PR for this change now.

[benjaminpjones]

I have a path forward to deliver the historical rating for the person who's page we are on.

Woo awesome! Thanks for the help with this, I didn't realize there was backend support needed when I started, but I think the changes you're adding will really make this sparkle :)

The weird thing is that this API also returns the ratings for the player of the "other" colour. In that case, I think I continue to return the "random" player in the "opposite" field - what else could it be?

For normal games, the ratings are shown in the opponent column so I think that makes sense. For rengo though, yeah I don't think I can logically show an "opponent" so random player (or no player) in that field is fine as far as the game history goes.

[anoek]

@benjaminpjones I just pushed up @GreenAsJade 's API support for you to beta so you can validate things are behaving as you expect and whatnot. I'm gonna mark this as draft, when you've banged on it against the beta API and things are working as expected mark as ready for merge

[benjaminpjones]

@anoek Sounds good! Just so I understand the backend changes, past games haven't been corrected right? I'll need to examine new rengo matches to see the changes?

Also, possibly related: when I go to beta.online-go.com I get a 500 error. The site still functions but I see the pop up when I visit the homepage.

EDIT: seems like 500 error for when I try to create/start a rengo match as well 😬

[anoek]

Sorry, beta should be fixed now, I forgot to run a migration.

I think the way @GreenAsJade wrote it, it should work for past games too.. but don't hold me to that :)

[benjaminpjones]

Awesome, thanks! API looks good, I'll need to make some minor changes to get the new information to show up.

[benjaminpjones]

Here's the table with those updates!

I think the way @GreenAsJade wrote it, it should work for past games too.. but don't hold me to that :)

Regarding what was backfilled, it looks like rengo_(black|white)_team and the historical_rankings changes show up in old games, but (black|white)_lost still hold the old values (which is probably fine as long as new games are correctly populated).

[GreenAsJade]

... it's definitely the case that _lost is computed at game completion, so won't be fixed by the code change, but ought to be correct now for new games.

(Edit: actually, that's what I thought when I was writing it, but I just had a "wait a minute" kind of thought, so either I'll go back and look or we'll find out, whichever happens first :D )

Nice table :) I kinda liked "fun was had", in sending the right message, but I guess ... my fun was had :D

[GreenAsJade]

^^ confirmed, it is "end_game_task", which runs once, that calculates and saves _lost.

[anoek]

Great work again @benjaminpjones :)