Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Announcements (and PMs etc.) for embeds #1909

Merged
merged 3 commits into from Jun 19, 2022
Merged

Hide Announcements (and PMs etc.) for embeds #1909

merged 3 commits into from Jun 19, 2022

Conversation

benjaminpjones
Copy link
Contributor

Fixes

Site notifications show up inside the embed 馃槃

https://forums.online-go.com/t/embed-live-game/42216/10

Proposed Changes

  • Just tell OGS we are in zen mode in embed panes
  • Remove NavBar hiding logic since it respects zen mode.

This feels like a bit of a hack since this isn't technically zen mode, but zen mode does so much, and embeds needs it all so why re-invent the wheel? :)

@benjaminpjones benjaminpjones marked this pull request as draft June 18, 2022 05:03
@benjaminpjones benjaminpjones marked this pull request as ready for review June 18, 2022 05:22
@benjaminpjones
Copy link
Contributor Author

benjaminpjones commented Jun 18, 2022

To explain that last commit - OldNavBar gets hidden a bit differently than everything else. The Game component was actually positioned to cover up the nav bar, instead of setting display: none as is done with most other components that get hidden during zen mode.

Relevant code points:

.Game.zen {
top: 0;
}

&.zen .Announcements {
display: none;
}

/body.zen & {
display: none;
}

&.zen .private-chat-window {
display: none;
}
&.zen .private-chat-window.superchat {
display: inline-block;
}

@anoek
Copy link
Member

anoek commented Jun 19, 2022

Awesome thanks!

@anoek anoek merged commit 08c004d into online-go:devel Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants