Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the conditional moves button in the dock in rengo games #1967

Merged
merged 1 commit into from Aug 15, 2022

Conversation

GreenAsJade
Copy link
Contributor

Fixes players messing things up by seeing what happens when you click the greyed out conditional moves button

Proposed Changes

Completely remove conditional moves button from Game Dock in rengo games.

(Note: previous implementation (probably by me) assumed that className disabled disables the link, but of course it doesn't. In the nearby cases in the code, the greyed link gets clicked and something down stream checks and decides not to do it. This is not practical in the case of conditional moves)

@anoek
Copy link
Member

anoek commented Aug 15, 2022

Thanks for the fix!

@anoek anoek merged commit 94977c0 into online-go:devel Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants