Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show handicap separately from handicap bonus #2507

Merged

Conversation

dexonsmith
Copy link
Contributor

Adapt to Goban change in online-go/goban#146 and show the actual handicap stones for black separately from the handicap bonus.

To make it clear that this handicap field is not part of the score:

  • Use a <hr/> to separate it
  • Add + in front of scores that are supposed to sum together.

Also move white's handicap bonus to the end, after komi.

  • This means that there's always a + in front of it, even at the beginning of the game, so it's implicitly clear that there's a bonus.
  • I considered changing the text to Handicap Bonus but that wrapped.

Relates to #1469

Adapt to Goban change in online-go/goban#146 and show
the actual handicap stones for black separately from the handicap bonus.

To make it clear that this handicap field is not part of the score:

- Use a `<hr/>` to separate it
- Add `+` in front of scores that are supposed to sum together.

Also move white's handicap bonus to the end, after komi.
- This means that there's always a `+` in front of it, even at the beginning of
  the game, so it's implicitly clear that there's a bonus.
- I considered changing the text to `Handicap Bonus` but that wrapped.

Relates to online-go#1469
Copy link

github-actions bot commented Jan 19, 2024

Uffizzi Preview deployment-44708 was deleted.

@dexonsmith
Copy link
Contributor Author

Some examples of how this looks (in combination with online-go/goban#146):

AGA:
aga
aga-after-moves

Japanese:
jp

NZ:
nz

@anoek
Copy link
Member

anoek commented Jan 20, 2024

Nice improvement, thanks!

@anoek anoek merged commit 2d4d0ad into online-go:devel Jan 20, 2024
4 checks passed
@dexonsmith dexonsmith deleted the show-handicap-separately-from-bonus branch January 20, 2024 17:58
@pdg137
Copy link
Contributor

pdg137 commented Jan 20, 2024

Yay, so nice to see things becoming consistent and easier to use across all rulesets.

In case it's easy to do, I'd like to also draw attention to a suggestion I made about displaying handicap along with the ruleset in the main game view:

image
link

Since just like the captures, that's basic information about the game that you might need to use to analyze the position, so it should be available without having to click anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants