Show handicap separately from handicap bonus #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt to Goban change in online-go/goban#146 and show the actual handicap stones for black separately from the handicap bonus. To make it clear that this handicap field is not part of the score: - Use a `<hr/>` to separate it - Add `+` in front of scores that are supposed to sum together. Also move white's handicap bonus to the end, after komi. - This means that there's always a `+` in front of it, even at the beginning of the game, so it's implicitly clear that there's a bonus. - I considered changing the text to `Handicap Bonus` but that wrapped. Relates to online-go#1469
|
Uffizzi Preview |
|
Some examples of how this looks (in combination with online-go/goban#146): AGA: Japanese: NZ: |
|
Nice improvement, thanks! |
|
Yay, so nice to see things becoming consistent and easier to use across all rulesets. In case it's easy to do, I'd like to also draw attention to a suggestion I made about displaying handicap along with the ruleset in the main game view: Since just like the captures, that's basic information about the game that you might need to use to analyze the position, so it should be available without having to click anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to Goban change in online-go/goban#146 and show the actual handicap stones for black separately from the handicap bonus.
To make it clear that this handicap field is not part of the score:
<hr/>to separate it+in front of scores that are supposed to sum together.Also move white's handicap bonus to the end, after komi.
+in front of it, even at the beginning of the game, so it's implicitly clear that there's a bonus.Handicap Bonusbut that wrapped.Relates to #1469