Indicate absolute time using '/*' and improve clock sorting #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borrow from the syntax for Canadian time to call out absolute time. - Canadian time says "3 Days/10" when there are 10 moves to make in 3 days. - With this, absoluate time says "3 Days/*".
|
In a game: |
|
Uffizzi Preview |
In game list sorting: - Always put non-correspondence games first - Divide Canadian block time by the number of remaining moves - Divide absolute time remaining by a guess of the remaining moves
|
I've also improved the urgency sorting in the game list to account for moves remaining in Canadian and absolute time, resulting in: For absolute time, the guess of moves remaining is based on the board size. Note: the top game there is a "live" game, which is why it sorts ahead of the absolute time. |
dexonsmith
changed the title
|
Nice improvement, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrow from the syntax for Canadian time to call out absolute time.
Addresses this forum thread asking for an indication in the game list of which games are using absolute time:
https://forums.online-go.com/t/suggestion-sort-games-with-absolute-time-settings-to-appear-at-the-top-of-ones-list-of-games-when-sorting-by-time-remaining/50649
EDIT: also improved sorting; details at #2557 (comment).