Wrap the <input> in chat boxes in a form and provide hint #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… browsers give users an enter button
|
Uffizzi Preview |
benjaminpjones
approved these changes
Feb 24, 2024
| @@ -17,23 +17,30 @@ | |||
|
|
|||
| import * as React from "react"; | |||
|
|
|||
| interface TabCompleteInputProperties { | |||
| interface TabCompleteInputProperties extends React.HTMLProps<HTMLInputElement> { | |||
There was a problem hiding this comment.
tbh this whole TabCompleteInputProperties type is unnecessary. Everything defined here is already defined in React.HTMLProps<HTMLInputElement>
|
Seems good on my devices, it's up on beta to smoke test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to try to ensure that phone browsers give users an enter button
Fixes ... hopefully... https://forums.online-go.com/t/unable-to-reply-to-group-chat/49861?u=greenasjade
Proposed Changes
inputin a non-submitformto provide a hint to phone browsers that this input needs an enter button