Update setExtraActionCallback whenever the tournament changes #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After f0a617a, tournament is immutable state (new copy on changes), not a mutable ref, so the renderExtraPlayerActions callback wasn't being kept up-to-date when the tournament changed. Split it out to its own `useEffect` that updates when the relevant tournament fields do. Tested: - Director of started tournament (disqualify and adjust points) - Director of not-started tournament (kick) - Non-director (no actions) - Switching between them via the search box, which reuses the same component Fixes online-go#2606
|
Uffizzi Preview |
|
Awesome thanks for digging into that and getting a fix so quick! |
dexonsmith
deleted the
update-setExtraActionCallback-when-tournament-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After f0a617a, tournament is immutable state (new copy on changes), not a mutable ref, so the renderExtraPlayerActions callback wasn't being kept up-to-date when the tournament changed. Split it out to its own
useEffectthat updates when the relevant tournament fields do.Tested:
Fixes #2606