#355: fix pre.previous_sibling become None Bug at yukicoder #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests make many access to onlinejudge servers. So I thought that we should reduce the number of CI runs, but now it seems we want to let CI run on other branches than master.
|
よさそうなのでマージします。 |
|
ただし、これではrebaseはできていなかったことは注意しておきます。
しかしrebaseをするというと不要なコミットを削除しながら組み換えて以下のような状態へすることを指します。
|
fukatani
added a commit
to fukatani/online-judge-tools
that referenced
this pull request
Jul 2, 2019
fukatani
added a commit
to fukatani/online-judge-tools
that referenced
this pull request
Jul 2, 2019
fukatani
added a commit
to fukatani/online-judge-tools
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre.previous_siblingとtestの修正をまとめて一つにしています。
もし何か間違っていたら再度修正します。