#380: fix AtCoderProblem.get_input_format() #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukatani
reviewed
Mar 20, 2019
| pre = section.find('pre') | ||
| if pre is not None: | ||
| return pre.decode_contents(formatter=None) | ||
| return None |
There was a problem hiding this comment.
正常な入力で、Noneが返ることはあるでしょうか？
あるなら、Noneが返る入力でテストがあったほうがいいと思います。
There was a problem hiding this comment.
入力形式が与えられない問題や、そもそも入力がない問題があります
- https://atcoder.jp/contests/tenka1-2013-quala/tasks/tenka1_2013_qualA_a
- https://atcoder.jp/contests/joi2006ho/tasks/joi2006ho_a
たしかにそのテストはあるべきでした。書きます
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #380
なんだか複数になってしまったが、やったのは以下です。