document.documentElement.clientHeight problem when search bar/bottom bar appears on devices #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to clientHeight , on iphone or other mobile devices the height wasn't calculated correctly if the search bar or the bottom bar on iphone appeared , so innerHeight made it possible to calculate the height everytime the bar on android/iphone appears
Update height calculation on mobileSelect.js
onlyhom
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to document.documentElement.clientHeight when on iphone/adroind appears the bottom bar or the searchbar the height is calculated incorrectly so the selector doesn't work as intended to and skips elements. That's why window.innerHeight helps keeping track of the window height and makes it possible to select even if the bar appears or dissapears