Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android push #14

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

atsushi-ageet
Copy link
Contributor

Currently Android Push seems to always fail.
I analyzed and fixed the problem.

@onmyway133 onmyway133 merged commit 8758307 into onmyway133:master Mar 13, 2019
@onmyway133
Copy link
Owner

@atsushi-ageet awesome 👍

@onmyway133 onmyway133 mentioned this pull request Mar 13, 2019
@alexcosmin
Copy link

@onmyway133 would it be possible to make a new release with this fix, so Android Push would work in the latest release? :)

@onmyway133 onmyway133 self-requested a review March 18, 2019 13:04
@Timo-Linde
Copy link

You can build this on your own:
Checkout the Repository
Install yarn (i did it with homebrew): brew install yarn
Add the electron-builder: yarn add electron-builder --dev
I needed to run the yarn add electron-builder command twice, dont know why
cd in the directory and run yarn dist

This worked for me

@onmyway133
Copy link
Owner

@atsushi-ageet @alexcosmin Hi, sorry for late reply, I just built it and made new release 1.4.0 https://github.com/onmyway133/PushNotifications/releases/tag/1.4.0

@atsushi-ageet atsushi-ageet deleted the fix-android-push branch April 10, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants