Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voip push #32

Merged
merged 1 commit into from Jan 22, 2020
Merged

Fix voip push #32

merged 1 commit into from Jan 22, 2020

Conversation

atsushi-ageet
Copy link
Contributor

voip push (Sandbox Environment) seems to fail.
Set apns-push-type to voip if voip push.

see: https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns/

@Ariandr
Copy link
Collaborator

Ariandr commented Jan 22, 2020

Hi @atsushi-ageet
Thanks for your PR.
Apple finally updated their documentation describing all possible apns-push-type values.

Have you done any testing of this change on your side?

@atsushi-ageet
Copy link
Contributor Author

Hi @Ariandr

Have you done any testing of this change on your side?

Yes, I confirmed that my iPhone can actually receive voip push(Production & Sandbox).

@Ariandr
Copy link
Collaborator

Ariandr commented Jan 22, 2020

@atsushi-ageet
Great!
Then I will create a new release with your PR. But also I want to add complication and fileprovider cases just in case someone needs it.

@Ariandr Ariandr merged commit 8c5a799 into onmyway133:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants