Adding support for iOS Live Activity push notifications #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mvandervelden The code change is straightforward, so If you tested and it works, I'll create a new release with this change. |
|
@Ariandr thanks for approving and merging! 🙇 |
|
@mvandervelden always happy to see people contributing❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As mentioned in these Apple Docs about the upcoming Live Activities feature. This feature will support using APNs push notifications, for which some specific headers are required:
apns-topicheader should have the format<your bundleID>.push-type.liveactivityapns-push-typeheader should beliveactivity.This PR
With this change, the Push Notifications app should support this new type of notifications, if users provide the correct apns-topic as bundleId (
<your bundleID>.push-type.liveactivity).Let me know if anything in the PR requires changing. This set up seems to work for me locally.