Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply mlagility to create ONNX model in CI #605

Merged
merged 57 commits into from
Jun 20, 2023
Merged

Apply mlagility to create ONNX model in CI #605

merged 57 commits into from
Jun 20, 2023

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented Apr 27, 2023

Description

  • Apply mlagility to create ONNX model in CI
  • TODO: upgrade several existing old ONNX models in ONNX model Zoo

Motivation
To make onnx models reproducible, apply mlagility to create ONNX model in CI.

@jcwchen
apply mlagility to create ONNX model in CI
a5a82ef 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen jcwchen added the CI label Apr 27, 2023
@jcwchen
correct path
9db5fb2 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
which benchit
65c5d7e 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
cd mlagility
d913609 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
pip install -e .
ccbaf72 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add models
b24081d 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
../mlagility_models/alexnet_torch_hub_2891f54c/onnx/
acf2326 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
git diff --exit-code -- .
2731ca4 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add opset 17 models
398b63d 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
add faster-rcnn in CIs
f6c54a1 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
cd
0c06ef3 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
use 18 instead of 17
ac5f5ec 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge branch 'jcw/add-mlagility' of https://github.com/jcwchen/models …
05c495d 
…into jcw/add-mlagility
@jcwchen
test opset_version 18
1a583ec 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen jcwchen marked this pull request as draft May 2, 2023 23:24
@jcwchen
git diff subdirectory
1f1db90 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
torch==2.0.0 torchvision==0.15.1
500b542 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
run_mlagility.py
ab889ae 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
use better path to store .onnx
0380b2f 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
print exception
6ff1014 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
copy
db69afb 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
+base_name
a0f0339 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
correct path from mlagility
dd41d77 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add another way to upload new model
2795d20 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
validate_model
37cf55e 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
import os.path as osp
cea6c52 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen jcwchen marked this pull request as ready for review June 14, 2023 16:24
@jcwchen
change path
e0f0ff0 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add new-models to CI trigger
358887a 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add test_data_set
bec94e5 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add .yml
2e99292 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
ls
9a1c97a 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
stdout=sys.stdout
6192ee7 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
change commit
53b3c98 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
ls .cache
0158b32 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
ls .cache/alexnet_torch_hub_7df2a577/onnx
6196319 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
ls
2f6d3ee 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
stdout=sys.stdout
cfeacf1 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
torch==2.0.0
38d44af 
torchvision==0.15.1

Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
mlagility_models_dir
d7d3d27 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
new config
7af0369 
Signed-off-by: jcwchen <jacky82226@gmail.com>
jcwchen
jcwchen commented Jun 14, 2023
View reviewed changes
workflow_scripts/config.py Outdated Show resolved Hide resolved
ramkrishna2910
ramkrishna2910 reviewed Jun 14, 2023
View reviewed changes
.github/workflows/mlagility_validation.yml
- name: Install dependencies and mlagility
run: |
python -m pip install --upgrade pip
python -m pip install onnx onnxruntime requests py-cpuinfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 36 installs both onnx and onnxruntime. Do we need a separate pip install here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are talking about this requirements: https://github.com/groq/mlagility/blob/main/models/requirements.txt, but actually onnx and onnxruntime are not there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation of MLAgility here installs onnx and onnxruntime

ramkrishna2910
ramkrishna2910 reviewed Jun 14, 2023
View reviewed changes
models/mlagility/requirements.txt
Comment on lines +1 to +2
torch==2.0.0
torchvision==0.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These requirements are also covered by mlagility. Do we need a separate requirements file here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, mlagility is still using torch<=1.14.0 according to https://github.com/groq/mlagility/blob/main/models/requirements.txt. ONNX needs PyTorch 2.0 here to convert opset_version 18.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MLAgility includes a setup.py that installs the base dependencies and a requirements.txt that installs additional packages for the mlagility/models.
The setup.py installs torch>=1.12.1 here which should install torch2.0.

@jcwchen
add 3 more models
355c6c3 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
add config
4dae47a 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
remove bert and gpt2 for now
0e1a570 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen
clean path
0ef4ef4 
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen jcwchen mentioned this pull request Jun 20, 2023
Merged
@jcwchen jcwchen merged commit d0f5e56 into onnx:new-models Jun 20, 2023
6 checks passed
@jcwchen jcwchen deleted the jcw/add-mlagility branch June 20, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramkrishna2910 ramkrishna2910 ramkrishna2910 approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcwchen @ramkrishna2910