Update Cast handlers for version 9 #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
chinhuang007
force-pushed
the
update-cast
branch
3 times, most recently
from
a769e91
to
477a5d6
Compare
tjingrant
reviewed
Feb 15, 2019
onnx_tf/handlers/backend/cast.py
Outdated
| @classmethod | ||
| def version_9(cls, node, **kwargs): | ||
| inp = kwargs["tensor_dict"][node.inputs[0]] | ||
| if (node.attrs.get("to") == tf.string): |
There was a problem hiding this comment.
It seems like casting from string type would cause problem?
For instance, if we want to convert "100" to 100, this handler would err.
There was a problem hiding this comment.
@tjingrant good catch! Updated handler and test code to cover cast from strings. Please review.
chinhuang007
force-pushed
the
update-cast
branch
2 times, most recently
from
a390a9b
to
c525605
Compare
chinhuang007
force-pushed
the
update-cast
branch
from
c525605
to
df7a7a7
Compare
The Cast operator was updated in ONNX opset version 9, causning frontend and backend conversion to fail. This PR should fix the issue: onnx#362
chinhuang007
force-pushed
the
update-cast
branch
from
df7a7a7
to
39f2aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cast operator was updated in ONNX opset version 9, causning
frontend and backend conversion to fail.
This PR should fix the issue:
#362