Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Slack join URL #120

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented May 31, 2022

Same as onnx/onnx#4108. Fix an issue reported by onnx/onnx#4197. I only fixed the link in news since it's an URL for joining. Not sure whether we should fix the Slack link in the top-right corner as well.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Copy link
Contributor

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreEichenberger
Copy link
Contributor

Let me know if you need me to merge them @jcwchen

@jcwchen
Copy link
Member Author

jcwchen commented Jun 20, 2022

Please merge it. Thank you @AlexandreEichenberger!

@AlexandreEichenberger AlexandreEichenberger merged commit f299d3b into onnx:main Jun 20, 2022
@AlexandreEichenberger
Copy link
Contributor

thanks @jcwchen for the fixes

@jcwchen jcwchen deleted the jcw/fix-slack branch June 20, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants