Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change contributing link #193

Merged
merged 1 commit into from
Dec 18, 2023
Merged

change contributing link #193

merged 1 commit into from
Dec 18, 2023

Conversation

inyong37
Copy link
Contributor

#192

There is an issue with the 'check out our contribution guide' button link, which redirects to an outdated path, resulting in a 404 error. I have addressed this by making the necessary corrections and submitting a pull request.

https://github.com/onnx/onnx/blob/main/docs/CONTRIBUTING.md#development

Screenshot 2023-12-14 at 11 36 23 AM

https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#development

Your review would be greatly appreciated :)

@andife
Copy link
Member

andife commented Dec 17, 2023

Thank you very much for your contribution. Can you fix the DCO? You should have instructions below? If these are not sufficient, do not hesitate to ask again.

Signed-off-by: Inyong Hwang <inyong1020@gmail.com>
@inyong37
Copy link
Contributor Author

Thank you very much for your contribution. Can you fix the DCO? You should have instructions below? If these are not sufficient, do not hesitate to ask again.

Thank you for reviewing the commit. I have updated the DCO.

@andife andife added this pull request to the merge queue Dec 18, 2023
Merged via the queue into onnx:main with commit 40aa588 Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants