You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to add IsNaN op and followed all the steps outlined here https://github.com/onnx/onnx/blob/master/docs/AddNewOp.md. When I run the python onnx/backend/test/stat_coverage.py && python onnx/defs/gen_doc.py, I find that the TestCoverage.md file gets updated with a lot more diffs than I'd expected. Attached is an example where I'm adding only the IsNaN operator. The consequence of this is that the build fails in the CI env.
Moreover a lot of model files get updated when running the update_doc.sh script. An example of the diff is attached here.
The reason is the precision problem on different platforms. So you may generate different results (output.pb) from the same inputs on different platforms.
I'm trying to add IsNaN op and followed all the steps outlined here https://github.com/onnx/onnx/blob/master/docs/AddNewOp.md. When I run the python onnx/backend/test/stat_coverage.py && python onnx/defs/gen_doc.py, I find that the TestCoverage.md file gets updated with a lot more diffs than I'd expected. Attached is an example where I'm adding only the IsNaN operator. The consequence of this is that the build fails in the CI env.
Moreover a lot of model files get updated when running the update_doc.sh script. An example of the diff is attached here.
diff.txt
The text was updated successfully, but these errors were encountered: