Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create down conversion for GroupNormalization-21 #5843

Open
justinchuby opened this issue Jan 4, 2024 · 0 comments
Open

Create down conversion for GroupNormalization-21 #5843

justinchuby opened this issue Jan 4, 2024 · 0 comments
Labels
contributions welcome tracking Tracking issues version converter Issues related to ONNX version converter
Milestone

Comments

@justinchuby
Copy link
Contributor

justinchuby commented Jan 4, 2024

When converters are adopting the new operator in opset 21, there will be needs for converting to lower opsets when users are trying to use runtimes that have not caught up with support.

The converter will help us adopt the latest opset without having to wait for all runtimes to catch up.

We don’t need to use the same operator (GroupNorm) when converting back, as long as the model is correct and accurate.

It is possible to use InstanceNorm and some transpose for it. For example https://github.com/microsoft/onnxscript/blob/172a81745c10467e04d9b4fdfa7829ce3321b6ce/onnxscript/function_libs/torch_lib/ops/core.py#L5850

@justinchuby justinchuby added version converter Issues related to ONNX version converter tracking Tracking issues labels Jan 4, 2024
@justinchuby justinchuby added this to the 1.16 milestone Jan 4, 2024
@justinchuby justinchuby self-assigned this Jan 17, 2024
@justinchuby justinchuby modified the milestones: 1.16, 1.17 Feb 8, 2024
@justinchuby justinchuby removed their assignment Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome tracking Tracking issues version converter Issues related to ONNX version converter
Projects
None yet
Development

No branches or pull requests

1 participant