Prevent unused variables from generating warnings across all platforms. #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled.
linkerzhang
approved these changes
Apr 12, 2019
houseroad
reviewed
Apr 12, 2019
|
@linkerzhang @houseroad can this be merged? thanks! |
hariharans29
pushed a commit
to hariharans29/onnx
that referenced
this pull request
Aug 15, 2019
…s. (onnx#1930) * Change the return type for the zipmap operator to match the description in the spec. * Prevent unused variables from generating warnings across all platforms. This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled. * nit change
wschin
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Pad spec update * More changes * More changes * Make pads and value attributes inputs in Pad operator * More changes * More changes * More cahnges * More changes * Remove tab * Fix formatting issues * More changes * Pad spec update * More changes * More changes * Prevent unused variables from generating warnings across all platforms. (#1930) * Change the return type for the zipmap operator to match the description in the spec. * Prevent unused variables from generating warnings across all platforms. This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled. * nit change * Shape Inference Tests for QOps (#1929) * fix shape inference and add tests for shape inference * cosmetic fixes * plus some formatting * Fix shape inference for matmul (#1941) * Fix shape inference for matmul when there is no input shape, and provide better coverage for testcases * add test for qlinearmatmul as weel * Make pads and value attributes inputs in Pad operator * More changes * More changes * More cahnges * More changes * Remove tab * Fix formatting issues * More changes * Fix line ending issue * Update Operators md file * Fix typo * Updating TestCoverage.md file * Nit fix * Fix accidental revert * PR feedback * More PR feedback changes * Optimizer passes changes * Remove unnecessary line in def file * More formatting changes * Add 2 files missed previously * Commit missed out file * Fix build break * Update tests * Initial commit * Formatting * Refactor ParseRawData * More refactroing changes * Introduce shape inference failure in case of wrong number of pad values * Resolve comments * Avoid vector copy * Fix comment * More changes * Update Changelog.md * Def changes * More updates * Formatting * Check-in tests * Update docs * Update Changelog.md * Docs update * Update Changelog.md * Update Changelog.md * Resolve comments * Add docs * Addign docs * Update Changelog.md * Build break fix * Fix build break * Add optimizer tests for older opset Pad * Add back older opset Pad shape inference tests * Fix build break * Fix build break * Account for Value to Constant_value change in some comments
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
…s. (onnx#1930) * Change the return type for the zipmap operator to match the description in the spec. * Prevent unused variables from generating warnings across all platforms. This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled. * nit change
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Pad spec update * More changes * More changes * Make pads and value attributes inputs in Pad operator * More changes * More changes * More cahnges * More changes * Remove tab * Fix formatting issues * More changes * Pad spec update * More changes * More changes * Prevent unused variables from generating warnings across all platforms. (onnx#1930) * Change the return type for the zipmap operator to match the description in the spec. * Prevent unused variables from generating warnings across all platforms. This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled. * nit change * Shape Inference Tests for QOps (onnx#1929) * fix shape inference and add tests for shape inference * cosmetic fixes * plus some formatting * Fix shape inference for matmul (onnx#1941) * Fix shape inference for matmul when there is no input shape, and provide better coverage for testcases * add test for qlinearmatmul as weel * Make pads and value attributes inputs in Pad operator * More changes * More changes * More cahnges * More changes * Remove tab * Fix formatting issues * More changes * Fix line ending issue * Update Operators md file * Fix typo * Updating TestCoverage.md file * Nit fix * Fix accidental revert * PR feedback * More PR feedback changes * Optimizer passes changes * Remove unnecessary line in def file * More formatting changes * Add 2 files missed previously * Commit missed out file * Fix build break * Update tests * Initial commit * Formatting * Refactor ParseRawData * More refactroing changes * Introduce shape inference failure in case of wrong number of pad values * Resolve comments * Avoid vector copy * Fix comment * More changes * Update Changelog.md * Def changes * More updates * Formatting * Check-in tests * Update docs * Update Changelog.md * Docs update * Update Changelog.md * Update Changelog.md * Resolve comments * Add docs * Addign docs * Update Changelog.md * Build break fix * Fix build break * Add optimizer tests for older opset Pad * Add back older opset Pad shape inference tests * Fix build break * Fix build break * Account for Value to Constant_value change in some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled.