-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper function update_inputs_outputs_dims to tools #2148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Please sign the updated CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one last question for import pdb
.
nit: rephrasing Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>
ff71cce
to
10c6225
Compare
* Add a helper function update_inputs_outputs_dims to tools * fix link to doc * newline at the end * add test for tools * doc props * nit * ci tests * ci tests 2 * accept shapes by dictionary inputs and add more error handling * Update onnx/tools/update_model_dims.py nit: rephrasing Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com> * remove debug line * fix type annotation * fix annotation * fix annotation * fix annotation * fix flake8
The function updates the dimension of the inputs and outputs of the model, to the provided values in the parameter. These values can be either static or dynamic. This can be useful for extending models with fixed input size to support dynamic input sizes.