Support ScatterND operator in ONNX #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2019
BowenBao
force-pushed
the
onnx_scatternd
branch
from
21b531d
to
d3f2798
Compare
spandantiwari
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Overall, Looks good. @BowenBao, Could you please address the comment related to TF reference?
BowenBao
force-pushed
the
onnx_scatternd
branch
from
d3f2798
to
af16433
Compare
|
A question: I believe indices should not have a repeated value, is that correct? That is, we cannot have two or more updates for the same index-location. If so, let us add that to the documentation. (I guess this is common with scatter too, I presume.) |
gramalingam
reviewed
Aug 15, 2019
gramalingam
reviewed
Aug 15, 2019
gramalingam
reviewed
Aug 15, 2019
BowenBao
force-pushed
the
onnx_scatternd
branch
from
af16433
to
b80ff34
Compare
|
@gramalingam Thanks for your detailed suggestions! I have updated the doc with clarification. You are right duplicate entries of indices is not supported. |
gramalingam
reviewed
Aug 15, 2019
|
@gramalingam - thanks for the review! |
|
@bddppq - for his review. |
|
@prasanthpul could you include this in ONNX 1.6 milestone as well? Thanks. |
fdwr
reviewed
Aug 23, 2019
BowenBao
force-pushed
the
onnx_scatternd
branch
2 times, most recently
from
be2d6e1
to
0548023
Compare
ebarsoum
approved these changes
Aug 27, 2019
BowenBao
force-pushed
the
onnx_scatternd
branch
from
0548023
to
a5614a9
Compare
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
Support ScatterND operator in ONNX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the inverse of GatherND #2106
This will support the exporting of
torch.masked_scatter,torch.index_put,torch.copy_,tf.scatter_nd_update, etc.