Fix shapeinference function #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarsoum
requested review from
postrational,
wschin,
spandantiwari and
ebarsoum
|
Could you please add a test into this file? |
Done. |
|
@ebarsoum, how does this PR look to you? |
spandantiwari
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
LGTM.
Aside - this is outside the scope of this change, but it may be useful to consider updating the cumsum op to allow specification of the output type from the user. For this kind of aggregation op it is quite possible that we run into overflow issues. Allowing the specification for output type allows the converter to choose a larger type for internal aggregation the cumulative sum and output.
ebarsoum
approved these changes
Sep 11, 2019
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Fix shapeinference function * Added shapeinference test for cumsum * update inference test * fix test * minor fix -- shape (1) should be (1,) * Add whitespace after comma to fix flake warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the shape inference function for CumSum.