Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about required input output types #2310

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

gramalingam
Copy link
Contributor

The types of inputs and outputs are required only for the top-level graph and not for subgraphs. Update the documentation to clarify this. (Also clarify documentation about variadic inputs and outputs.)

@gramalingam gramalingam requested a review from a team as a code owner September 13, 2019 17:49
@gramalingam gramalingam added this to the 1.6 milestone Sep 13, 2019
@gramalingam gramalingam added the documentation Issues related to ONNX documentation label Sep 13, 2019
@houseroad
Copy link
Member

@gramalingam do you have more context on in which condition, subgraph should not provide type information?

@gramalingam
Copy link
Contributor Author

@houseroad : see Issue #2286 and the earlier PR #2009

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thanks.

@gramalingam gramalingam merged commit 3e6382b into onnx:master Sep 13, 2019
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
@gramalingam gramalingam deleted the update-doc-io-types branch April 14, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues related to ONNX documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants