Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep symbolic dims in Concat with a single input #2418

Merged
merged 5 commits into from
Jan 14, 2020

Conversation

shinh
Copy link
Member

@shinh shinh commented Oct 25, 2019

When there is only a single input, we need to discard the
symbolic dimension in the specified axis.

@shinh shinh requested review from a team as code owners October 25, 2019 08:55
When there is only a single input, we need to discard the
symbolic dimension in the specified axis.
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@linkerzhang linkerzhang reopened this Jan 14, 2020
@linkerzhang linkerzhang merged commit 684fc1b into onnx:master Jan 14, 2020
@winnietsang winnietsang added this to the 1.7 milestone Feb 12, 2020
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
* Keep symbolic dims in Concat with a single input

When there is only a single input, we need to discard the
symbolic dimension in the specified axis.

* Validate axis of Concat with a single input

Co-authored-by: Ke Zhang <kezhan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants