New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ConvTranspose: enhance attribute check #3000
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3cf1f0d
add check for using auto_pad and pads simultaneously
jcwchen e75e287
fix description for auto_pads == SAME_UPPER
jcwchen 70952c0
update docs for operator
jcwchen 8a0482d
fix the old one as well
jcwchen 05af6f1
add a test
jcwchen 80d6166
Merge branch 'master' into fix-convtranspose
jcwchen c319c96
Merge branch 'master' into fix-convtranspose
jcwchen 6473362
Merge branch 'master' into fix-convtranspose
askhade f2cfb6a
Revert "fix description for auto_pads == SAME_UPPER"
jcwchen 09bbe48
Revert "update docs for operator"
jcwchen c4a9bb0
Revert "fix the old one as well"
jcwchen 4f0dc32
Merge branch 'master' into fix-convtranspose
jcwchen 975f68b
Merge branch 'master' into fix-convtranspose
askhade File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit: this is neither a shape_inference error nor a type_inference error. Unfortunately, we have only "fail_type_inference" and "fail_shape_inference". This is okay, but it might be good to have a consistent categorization of errors (may be adding another category of errors) ... not necessarily in this PR, could be later also.